Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UIKIT-4240): implement basic quote reply logic #103

Merged
merged 4 commits into from
Jul 13, 2023

Conversation

bang9
Copy link
Collaborator

@bang9 bang9 commented Jul 9, 2023

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team developer-advocates@sendbird.com with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

UIKIT-4240

Description Of Changes

  • Implement scroll to parent message
  • Implement send reply messages
  • Add placeholder ui (message > parent message)
  • Add placeholder ui (input > parent message preview)
  • Add marks for message bottom sheet items
    • reply
    • delete

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2023

Codecov Report

Patch coverage: 2.77% and project coverage change: -0.16 ⚠️

Comparison is base (2f95583) 14.04% compared to head (d8616e5) 13.89%.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           feat/quote-reply     #103      +/-   ##
====================================================
- Coverage             14.04%   13.89%   -0.16%     
====================================================
  Files                   315      315              
  Lines                  6242     6324      +82     
  Branches               1736     1766      +30     
====================================================
+ Hits                    877      879       +2     
- Misses                 5297     5376      +79     
- Partials                 68       69       +1     
Impacted Files Coverage Δ
...t-native/src/components/ChannelInput/SendInput.tsx 0.00% <0.00%> (ø)
...react-native/src/components/ChannelInput/index.tsx 0.00% <0.00%> (ø)
...native/src/components/ChannelMessageList/index.tsx 0.00% <0.00%> (ø)
...sageRenderer/GroupChannelMessageFocusAnimation.tsx 0.00% <0.00%> (ø)
...c/components/GroupChannelMessageRenderer/index.tsx 0.00% <0.00%> (ø)
...omain/groupChannel/component/GroupChannelInput.tsx 0.00% <0.00%> (ø)
...groupChannel/component/GroupChannelMessageList.tsx 0.00% <0.00%> (ø)
...e/src/domain/groupChannel/module/moduleContext.tsx 0.00% <0.00%> (ø)
...ative/src/fragments/createGroupChannelFragment.tsx 0.00% <0.00%> (ø)
...lMessages/useGroupChannelMessagesWithCollection.ts 40.59% <60.00%> (+0.39%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bang9 bang9 changed the title feat: implement basic reply logic feat: implement basic quote reply logic Jul 9, 2023
@bang9 bang9 changed the title feat: implement basic quote reply logic feat(UIKIT-4240): implement basic quote reply logic Jul 9, 2023
@bang9 bang9 requested a review from chrisallo July 9, 2023 17:27
@bang9 bang9 self-assigned this Jul 9, 2023
@bang9 bang9 force-pushed the feat/quote-reply-logic branch from d8616e5 to 8a86770 Compare July 10, 2023 01:28
@bang9 bang9 force-pushed the feat/quote-reply-logic branch from 8a86770 to 4fb8be1 Compare July 10, 2023 01:45
Copy link
Contributor

@chrisallo chrisallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bang9 bang9 merged commit 2202e3b into feat/quote-reply Jul 13, 2023
@bang9 bang9 deleted the feat/quote-reply-logic branch July 13, 2023 02:01
bang9 added a commit that referenced this pull request Jul 21, 2023
* chore: implement basic reply logic
* chore: implement scroll to message logic
* chore: optional mark for open channel
* chore: added disabled mark to delete message action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants