-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(UIKIT-4240): implement basic quote reply logic #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feat/quote-reply #103 +/- ##
====================================================
- Coverage 14.04% 13.89% -0.16%
====================================================
Files 315 315
Lines 6242 6324 +82
Branches 1736 1766 +30
====================================================
+ Hits 877 879 +2
- Misses 5297 5376 +79
- Partials 68 69 +1
☔ View full report in Codecov by Sentry. |
bang9
changed the title
feat: implement basic reply logic
feat: implement basic quote reply logic
Jul 9, 2023
bang9
changed the title
feat: implement basic quote reply logic
feat(UIKIT-4240): implement basic quote reply logic
Jul 9, 2023
bang9
force-pushed
the
feat/quote-reply-logic
branch
from
July 10, 2023 01:28
d8616e5
to
8a86770
Compare
bang9
force-pushed
the
feat/quote-reply-logic
branch
from
July 10, 2023 01:45
8a86770
to
4fb8be1
Compare
chrisallo
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
bang9
added a commit
that referenced
this pull request
Jul 21, 2023
* chore: implement basic reply logic * chore: implement scroll to message logic * chore: optional mark for open channel * chore: added disabled mark to delete message action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External Contributions
This project is not yet set up to accept pull requests from external contributors.
If you have a pull request that you believe should be accepted, please contact
the Developer Relations team developer-advocates@sendbird.com with details
and we'll evaluate if we can setup a CLA to allow for the contribution.
For Internal Contributors
UIKIT-4240
Description Of Changes
Types Of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that apply_