From b1a1ccf2237c9f32a9a704b05c56309d8e9c83f5 Mon Sep 17 00:00:00 2001 From: Sam Harrison Date: Tue, 30 Jun 2020 08:50:24 -0500 Subject: [PATCH] fix: don't use dependency version ranges Using a version range like this results in maven attempting to get SNAPSHOT information for the dependency since it's possible a SNAPSHOT release would match the version range. It's not a big deal, but there are better approaches. The idea was we want to pick up the latest 4.X version of java-http-client, but even a version range does not guarantee this. It only guarantees that a 4.X version will be used (not necessarily the latest release). What we really want is the latest non-snapshot, minor version release for all dependencies, not just java-http-client. Also note that Maven version ranges perform basic string comparison so even it they were capable of getting the latest release for a dependency, it might not actually be the latest release if proper semver is used. --- pom.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pom.xml b/pom.xml index 432908f1..081690eb 100644 --- a/pom.xml +++ b/pom.xml @@ -274,7 +274,7 @@ com.sendgrid java-http-client - [4.2,5.0) + 4.3.3 com.fasterxml.jackson.core @@ -300,7 +300,7 @@ org.mockito mockito-core - 2.1.0 + 2.28.2 test @@ -309,4 +309,4 @@ 1.65 - \ No newline at end of file +