Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API credentials validation does not clean up hostname #37

Closed
kaittodesk opened this issue Nov 18, 2020 · 0 comments · Fixed by #44
Closed

API credentials validation does not clean up hostname #37

kaittodesk opened this issue Nov 18, 2020 · 0 comments · Fixed by #44
Labels
bug Something isn't working

Comments

@kaittodesk
Copy link
Member

Bug description
When using FQDN value in subdomain field during API credentials validation, the validation fails.

Steps for reproducing
Steps to reproduce the behavior:

  1. Go to edit a Contact Form;
  2. Click on Smaily for Contact Form 7 tab;
  3. Fill out API credential fields, where subdomain field contains a fully-qualified domain name (e.g. example.sendsmaily.net);
  4. Click on Verify credentials button;

Expected behavior
API credentials are verified and select with autoresponders is shown.

Actual behavior
API credentials verification fails.

Versions
Wordpress: 5.4.1
Contact Form 7: 5.1.7
Smaily for Contact Form 7: 1.0.3

Additional context
I think the issue is that subdomain clean up regular expression is broken. There's a lot of whitespace and array(...) in the expression:

https://github.com/sendsmaily/smaily-cf7-plugin/blob/master/admin/class-smaily-for-cf7-admin.php#L335-L349

@kaittodesk kaittodesk added the bug Something isn't working label Nov 18, 2020
@ghost ghost mentioned this issue Dec 14, 2020
11 tasks
@ghost ghost closed this as completed in #44 Dec 15, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant