Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): Do not autofill ssid and password #301

Merged
merged 1 commit into from
Apr 5, 2019
Merged

Conversation

mpfeil
Copy link
Member

@mpfeil mpfeil commented Mar 26, 2019

Do not autofill ssid and password fields if password is saved for website

fixes #295

Fix or Enhancement and description?

Do not autofill ssid and password fields in edit section and registration.

Do not autofill ssid and password fields if password is saved for website

fixes #295
@mpfeil
Copy link
Member Author

mpfeil commented Mar 26, 2019

@janwirwahn @ubergesundheit @noerw could you test the fix please?
I have tested Chrome and Firefox on Arch.

@noerw thans for the hint with the name attribute.

For Chrome you must specify name and autocomplete. For Firefox you need a hidden input element.

@ubergesundheit
Copy link
Member

Works in Firefox 66.0.1 on Ubuntu 18.04 (But I don't have any credentials stored in my browser, so I may not the best to test this)

@chk1
Copy link
Contributor

chk1 commented Mar 26, 2019

Just a quick note, autocomplete="new-password" is in the works for Firefox version 67 (Bugzilla 1119063), to be released in May

@mpfeil mpfeil merged commit 1b55c9a into development Apr 5, 2019
@felixerdy felixerdy deleted the autofill branch October 12, 2020 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants