Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

caching parsed files #195

Merged
merged 5 commits into from
Jan 6, 2019
Merged

caching parsed files #195

merged 5 commits into from
Jan 6, 2019

Conversation

smoench
Copy link
Contributor

@smoench smoench commented Nov 16, 2018 •
edited
Loading

closes #71
closes #144

@smoench smoench force-pushed the cache branch 3 times, most recently from 7e71420 to 6a929ce Compare November 16, 2018 14:12
@smoench smoench changed the title WIP: experimental cache parsed files WIP: experimental caching parsed files Nov 16, 2018
@smoench smoench force-pushed the cache branch 2 times, most recently from 2f066a2 to 8f555aa Compare November 23, 2018 13:09
@smoench smoench added this to the 0.4 milestone Nov 23, 2018
@smoench smoench force-pushed the cache branch 3 times, most recently from ca3a424 to ed40835 Compare December 20, 2018 12:17
@smoench
Copy link
Contributor Author

smoench commented Dec 21, 2018

It might be a good idea adding an option for deactivating the caching mechanism.

smoench
smoench commented Jan 2, 2019
View reviewed changes
box.json.dist
@@ -1,11 +1,11 @@
{
"compactors": [
"KevinGH\\Box\\Compactor\\Json",
"KevinGH\\Box\\Compactor\\Php",
"KevinGH\\Box\\Compactor\\PhpScoper"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHPScoper needs to be removed as PhpParser\JsonDecoder relies on the original namespace.

@smoench smoench changed the title WIP: experimental caching parsed files caching parsed files Jan 2, 2019
@smoench smoench merged commit 8fd229e into master Jan 6, 2019
@DavidBadura DavidBadura deleted the cache branch January 7, 2019 08:57
@ohartl ohartl mentioned this pull request Jan 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timglabisch timglabisch timglabisch left review comments

@DavidBadura DavidBadura DavidBadura left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4
Development

Successfully merging this pull request may close these issues.

Create a cache to speedup Cache parsing
3 participants
@smoench @DavidBadura @timglabisch