Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mechanism for only pulling resources in the check's namespace #45

Open
metrictwo opened this issue Aug 8, 2018 · 0 comments
Open

Comments

@metrictwo
Copy link

metrictwo commented Aug 8, 2018

Currently, plugins will pull pods and services at the cluster scope and then prune them against namespace-limiting options (-i|--include-namespace and -n|--exclude-namespace). This assumes that the pod running the check can read resources at the cluster scope, preventing multi-tenant cluster users from running their own per-namespace clients (well, without doling out overly-generous RBAC perms, that is). A few possible options:

  • Modify --include-namespace to explicitly pull resources from the provided namespace(s) individually, rather than pulling cluster-wide and then pruning.
  • Add a flag specifying cluster-wide vs namespaced usage. Examples:
    • --cluster-wide=<bool> (true by default)
    • --namespaced=<bool> (false by default)
  • Add a --namespace [NS] option to specify the namespace in which to operate. Perhaps the argument could be optional, with the current namespace used when not specified.

I am happy to perform this work, although input on a preferred route would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant