Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support symlinks in --log-path #22

Open
agoddard opened this issue Oct 5, 2021 · 1 comment
Open

Support symlinks in --log-path #22

agoddard opened this issue Oct 5, 2021 · 1 comment

Comments

@agoddard
Copy link

agoddard commented Oct 5, 2021

Presently symlinks don't work for --log-path args, but it would be 💯 if they did

@jspaleta
Copy link
Contributor

jspaleta commented Oct 6, 2021

This is probably a wont fix for now as it will require a significant development effort.

Walking the directory structure that uses symlinks will not work the existing golang filepath.Walk function does not follow symlinks. To support this will need a redesign of existing behavior and replacing the filepath.Walk function with a bespoke implementation that is able to follow nested directory symlinks without breaking regexp expression matching.

Example of what I'm talking about..

lets say you have a regexp that wants to look for filepaths hat end in "log" but start with "/var/log/" that's a valid regexp.

But lets now say that you have "/var/log/" as a symlink to something like "/var/tmp/logs" the regexp described above will no longer match because once you evaluate the symlinks to get the real path on disk... the regexp logic will be using that real path not the symlink.

This gets complicated further once you have nested directory symlinks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants