Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to etcd 3.4 #3729

Closed
4 tasks
palourde opened this issue May 1, 2020 · 7 comments
Closed
4 tasks

Upgrade to etcd 3.4 #3729

palourde opened this issue May 1, 2020 · 7 comments
Assignees
Milestone

Comments

@palourde
Copy link
Contributor

palourde commented May 1, 2020

Background

We should consider upgrading etcd to v3.4. There's a couple of significant improvements that we could probably benefit from. Additionally, etcd now recommends 3.3.18+, and 3.4.2+ as minimal versions for production.

One important thing to notice is that etcd 3.4 switched to go modules and is now known as the go.etcd.io/etcd/v3 module, which signifies we will need to update the import path in our codebase.

Acceptance Criteria

  • sensu-go with etcd 3.4 is benchmarked to make sure it doesn't introduce any performance regression
  • The new 3.4 features are reviewed and spikes and/or feature requests are open if there's anything significant we should explore/implement.

Definition of Done

  • sensu-backend w/ etcd 3.4 is benchmarked
  • sensu-backend w/ etcd 3.4 passes the automated QA
@palourde
Copy link
Contributor Author

palourde commented May 4, 2020

We might have to wait for 3.5: etcd-io/etcd#11154

@calebhailey calebhailey added the component:backend Sensu Backend improvements label May 18, 2020
@nikkictl
Copy link

For multiple reasons (described in #3760 (comment)), we must wait for etcd v3.5 to update etcd, bolt, and go.

@portertech
Copy link
Contributor

@eric to comment.

@eric
Copy link

eric commented May 19, 2020

I have no comment 😬

@nikkictl nikkictl changed the title Upgrade to etcd 3.4 Upgrade to etcd 3.5 May 19, 2020
@portertech
Copy link
Contributor

@eric This made my day 😆

Will the real @echlebek please stand up.

@nikkictl
Copy link

We can track the v3.5 milestone here: https://github.com/etcd-io/etcd/milestone/37

@portertech portertech changed the title Upgrade to etcd 3.5 Upgrade to etcd 3.4 Nov 2, 2020
@portertech portertech added this to the 6.3.0 milestone Nov 16, 2020
@portertech portertech modified the milestones: 6.3.0, 6.4.0 Dec 7, 2020
@amdprophet
Copy link
Member

Implemented in #4229.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants