Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow kube-fledged to be deployed in any namespace #52

Closed
edshelton opened this issue Feb 24, 2020 · 1 comment
Closed

Allow kube-fledged to be deployed in any namespace #52

edshelton opened this issue Feb 24, 2020 · 1 comment
Assignees
@senthilrch
Labels
enhancement Enhancement to existing feature

Comments

@edshelton
Copy link

IMO hardcoding the namespace which the controller lives in is an antipattern:

https://github.com/senthilrch/kube-fledged/search?q=fledgedNameSpace&unscoped_q=fledgedNameSpace

Can this be changed so that kube-fledged can be deployed to any namespace?

E0224 13:17:38.339997       1 image_manager.go:442] Error creating job in node ip-10-0-30-82: namespaces "kube-fledged" not found
E0224 13:17:38.340905       1 image_manager.go:424] error pulling image 'golang:1.13' to node 'ip-10-0-30-82': namespaces "kube-fledged" not found
@senthilrch senthilrch self-assigned this Feb 25, 2020
@senthilrch senthilrch added the enhancement Enhancement to existing feature label Feb 25, 2020
@senthilrch
Copy link
Owner

I'll have this changed to support deployment to any namespace. Will implement for v0.6.0

@senthilrch senthilrch mentioned this issue Feb 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@senthilrch senthilrch

Labels
enhancement Enhancement to existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@senthilrch @edshelton