Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge THIS PR #915 - FIXES incorrect default config for internal_replication #1383

Closed
chipzzz opened this issue Aug 9, 2024 · 2 comments
Closed
Labels

Comments

@chipzzz
Copy link

chipzzz commented Aug 9, 2024

Merge this PR please, the current config is entirely incorrect and default value in the helm chart are NOT valid or true.

#915

Today the helm chart still shows true. So anyone coming into chart is thinking this is set true by default. The deployment itself is incorrect as the parameter is deployed on the wrong section.

This could be drastic when trying to fully fix distributed/sharded mode of snuba/clickhouse. Based on the findings mentioned in the official CH docs the placement of this config is entirely incorrect so this has been always false as mentioned by @zetaab .

This PR should be merged so that there's no confusion about default config. Today the config is still deployed in the wrong spot making the setting False, yet the helm chart says it's true

@Mokto
Copy link
Contributor

Mokto commented Sep 9, 2024

This issue is stale because it has been open for 30 days with no activity.

@Mokto Mokto added the stale label Sep 9, 2024
@Mokto
Copy link
Contributor

Mokto commented Sep 23, 2024

This issue was closed because it has been inactive for 14 days since being marked as stale.

@Mokto Mokto closed this as not planned Won't fix, can't repro, duplicate, stale Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants