You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Today the helm chart still shows true. So anyone coming into chart is thinking this is set true by default. The deployment itself is incorrect as the parameter is deployed on the wrong section.
This could be drastic when trying to fully fix distributed/sharded mode of snuba/clickhouse. Based on the findings mentioned in the official CH docs the placement of this config is entirely incorrect so this has been always false as mentioned by @zetaab .
This PR should be merged so that there's no confusion about default config. Today the config is still deployed in the wrong spot making the setting False, yet the helm chart says it's true
The text was updated successfully, but these errors were encountered:
Merge this PR please, the current config is entirely incorrect and default value in the helm chart are NOT valid or true.
#915
Today the helm chart still shows true. So anyone coming into chart is thinking this is set true by default. The deployment itself is incorrect as the parameter is deployed on the wrong section.
This could be drastic when trying to fully fix distributed/sharded mode of snuba/clickhouse. Based on the findings mentioned in the official CH docs the placement of this config is entirely incorrect so this has been always false as mentioned by @zetaab .
This PR should be merged so that there's no confusion about default config. Today the config is still deployed in the wrong spot making the setting False, yet the helm chart says it's true
The text was updated successfully, but these errors were encountered: