Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize the messages for all the criteria tests #432

Closed
NassimBtk opened this issue Sep 30, 2024 · 0 comments · Fixed by #453
Closed

Standardize the messages for all the criteria tests #432

NassimBtk opened this issue Sep 30, 2024 · 0 comments · Fixed by #453
Assignees
@CherfaElyes
Labels
enhancement New feature or request
Milestone
v0.9.08

Comments

@NassimBtk
Copy link
Member

NassimBtk commented Sep 30, 2024 •
edited
Loading 

          Each extension provides the messages in a specific format. We need to normalize all the messages. It is a huge work but we should do that to get normalized messages for BMC or even for OTEL logs.

Originally posted by @NassimBtk in #431 (comment)

Specification

TBD: Specify a generic message format.
@NassimBtk NassimBtk added the enhancement New feature or request label Sep 30, 2024
@NassimBtk NassimBtk mentioned this issue Sep 30, 2024
Merged
@CherfaElyes CherfaElyes self-assigned this Oct 16, 2024
CherfaElyes added a commit that referenced this issue Oct 17, 2024
@CherfaElyes
Issue #432: Standardize the messages for all the criteria tests
4931b3f 
* Added a displayCriterionMessage method that displays the same message format for all the CriterionTestResult.
* Adapted unit tests.
* Tested on MetricsHub.
@CherfaElyes CherfaElyes linked a pull request Oct 17, 2024 that will close this issue
Issue #432: Standardize the messages for all the criteria tests #453
Merged
CherfaElyes added a commit that referenced this issue Oct 22, 2024
@CherfaElyes
Issue #432: Standardize the messages for all the criteria tests
f425f37 
* Made little changes to improve code.
* Added Javadoc.
* Tested on MetricsHub
CherfaElyes added a commit that referenced this issue Oct 22, 2024
@CherfaElyes
Issue #432: Standardize the messages for all the criteria tests
8379943 
* Reformatted the code.
@NassimBtk NassimBtk added this to the 1.0.02 milestone Oct 22, 2024
NassimBtk added a commit that referenced this issue Oct 22, 2024
@NassimBtk
Merge pull request #453 from sentrysoftware/feature/issue-432-standar…
1bf13cc 
…dize-the-messages-for-all-the-criteria-tests

Issue #432: Standardize the messages for all the criteria tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CherfaElyes CherfaElyes

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.9.08
Development

Successfully merging a pull request may close this issue.

Issue #432: Standardize the messages for all the criteria tests sentrysoftware/metricshub
2 participants
@NassimBtk @CherfaElyes