Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing graph flag values #69

Closed
sadrasabouri opened this issue Sep 17, 2020 · 5 comments · Fixed by #81
Closed

Changing graph flag values #69

sadrasabouri opened this issue Sep 17, 2020 · 5 comments · Fixed by #81
Assignees
@ahmadsalimi
Labels
enhancement
Milestone
pyrgg 1.0

Comments

@sadrasabouri
Copy link
Collaborator

Description

In main menu each flag assigned by 1 or 2, but it seems more friendly if it changes to 0 or 1.
In second situation debugging may be more easy.
This issue may include these flags:

  • weighted
  • direct
  • self_loop
  • multigraph (which can be changed to singlegraph to seems more ordered)
@sepandhaghighi sepandhaghighi mentioned this issue Oct 18, 2020
Merged
@sepandhaghighi
Copy link
Owner

@ahmadsalimi Do you have any interest to work on this issue after #68?

@ahmadsalimi
Copy link
Contributor

@ahmadsalimi Do you have any interest to work on this issue after #68?

@sepandhaghighi
I will work on this. But, I have a question. Why shouldn't we use boolean values for flags?

@sepandhaghighi sepandhaghighi added this to the pyrgg 1.0 milestone Oct 19, 2020
@sepandhaghighi
Copy link
Owner

@sepandhaghighi
I will work on this. But, I have a question. Why shouldn't we use boolean values for flags?

There is no difference at all. But mostly it's because of user inputs and function parameters be sync.
I suggest 0 and 1

@sepandhaghighi
Copy link
Owner

sepandhaghighi commented Oct 19, 2020 •
edited
Loading

@ahmadsalimi
I received your removed comment email.
Please do what you think it's better, I'm waiting for your PR 💯

@ahmadsalimi ahmadsalimi mentioned this issue Oct 21, 2020
Merged
@ahmadsalimi
Copy link
Contributor

@ahmadsalimi
I received your removed comment email.
Please do what you think it's better, I'm waiting for your PR 💯

@sepandhaghighi 😄😄😄😄😄😄😄😄😄

Thank you Sepand, I'm working on it.

@sepandhaghighi sepandhaghighi mentioned this issue Jan 9, 2021
Merged
@sepandhaghighi sepandhaghighi linked a pull request Jan 9, 2021 that will close this issue
Version 1.0 #81
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahmadsalimi ahmadsalimi

Labels
enhancement
Projects
None yet
Milestone
pyrgg 1.0
Development

Successfully merging a pull request may close this issue.

Version 1.0 sepandhaghighi/pyrgg
3 participants
@sepandhaghighi @sadrasabouri @ahmadsalimi