From a8ba2f3544a1c01c57f217c4036a277ab0e67a09 Mon Sep 17 00:00:00 2001
From: tidusjar <tidusjar@gmail.com>
Date: Thu, 10 Mar 2022 11:55:11 +0000
Subject: [PATCH] fix: :bug: Fixed the Request On Behalf autocomplete not
 filtering correctly

#4539
---
 .../admin-request-dialog.component.ts                    | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/src/Ombi/ClientApp/src/app/shared/admin-request-dialog/admin-request-dialog.component.ts b/src/Ombi/ClientApp/src/app/shared/admin-request-dialog/admin-request-dialog.component.ts
index acf6560b9..d495a88e7 100644
--- a/src/Ombi/ClientApp/src/app/shared/admin-request-dialog/admin-request-dialog.component.ts
+++ b/src/Ombi/ClientApp/src/app/shared/admin-request-dialog/admin-request-dialog.component.ts
@@ -1,7 +1,7 @@
 import { Component, Inject, OnInit } from "@angular/core";
 import { FormBuilder, FormGroup } from "@angular/forms";
 import { MatDialogRef, MAT_DIALOG_DATA } from "@angular/material/dialog";
-import { Observable } from "rxjs";
+import { firstValueFrom, Observable } from "rxjs";
 import { startWith, map } from "rxjs/operators";
 import { ILanguageProfiles, IRadarrProfile, IRadarrRootFolder, ISonarrProfile, ISonarrRootFolder, ISonarrSettings, IUserDropdown, RequestType } from "../../interfaces";
 import { IdentityService, MessageService, RadarrService, RequestService, SettingsService, SonarrService } from "../../services";
@@ -55,7 +55,7 @@ export class AdminRequestDialogComponent implements OnInit {
         radarrFolderId: [null]
     })
 
-    this.options = await this.identityService.getUsersDropdown().toPromise();
+    this.options = await firstValueFrom(this.identityService.getUsersDropdown());
 
     this.filteredOptions = this.form.controls['username'].valueChanges.pipe(
       startWith(""),
@@ -96,7 +96,10 @@ export class AdminRequestDialogComponent implements OnInit {
   public displayFn(user: IUserDropdown): string {
     const username = user?.username ? user.username : "";
     const email = user?.email ? `(${user.email})` : "";
-    return `${username} ${email}`;
+    if (username && email) {
+      return `${username} ${email}`;
+    }
+    return '';
   }
 
   private _filter(value: string | IUserDropdown): IUserDropdown[] {