-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new device support: OP7/OP7P #14
Comments
hi @darkr4y ,
There isn't one yet, but I might find some time to compose one at some point. In the meantime I can suggest Kali NetHunter's git repo in GitLab -- it should have most of the kernel patches necessary for the modification. And in the case of OP7 specifically, there seems to be some work done for it already. Problem is, it's outdated, but it can be a foundation for bringing NetHunter into latest LineageOS builds for OP7.
Sure, I don't have an OP7 myself, so it would be welcomed for someone to add a verified support for it here. |
Thanks for the reply, I read the code as well as made the following attempts
error 2
error 3
My question is |
@darkr4y ,
Yes, I see the issue.
This might be related to |
thx for reply, I switch to dev branch and keep testing.
I checked the version of dtc used
I also specified the version which installed via apt
but there are still errors, which seem to be related to some compilation options in defconfig, could you give some advice? |
@darkr4y ,
Yes, the logging system in the builder has been a problem, which is why the parameter is non-functional now. I've got plans on reworking it, but for now using
You can try adding it in the Dockerfile and see if it fixes your issue. If it does, this can potentially be added in your PR.
Honestly, can't tell much about it. This requires a deeper analysis of the logs and the kernel source. Maybe if
Generally you could try looking into here. This should give an idea of what Once you know what to change, the primary location of defconfig modification within the builder is here. You can add a condition for OP7 and add and/or remove specific |
for the dtc syntax error, I forget set DTC_EXT env vars, so the dtc binary used in building is always in another path (
I'll test the availability of the nethunter kernel on a real OP7P phone, thx for reply :) |
It's very strange, I confirmed from the compilation log that no errors were generated and the compilation was successful
but I don't see the kernel image in the zip file of anykernel package.
Reviewing the code reveals that only
|
@darkr4y ,
For different Android kernels (at least that is the case for the non-GKI ones), the image file can exist in several formats, incl. With that said, according to currently existing OP7 kernel artifacts, the image file for this device should be In any case, If the final kernel zip works for the device properly, then it can be considered a success; if otherwise, then it would make sense to review the build modifications/settings/etc to narrow down the potential issue. |
I tried to manually change the configuration of the defconfig specified in the kernel source directory to add the compilation option for |
@darkr4y ,
That's expected, the builder resets the kernel source directory to a clean state each time it is launched, after which it applies all the patches -- including defconfig modification -- and starts the build. This is intentional, so that each kernel build is free of any potential artifacts from any of the previous attempts. As mentioned before, the defconfig modification is primarily done in here. This way, no matter what unrelated to NetHunter I can see though why this can be viewed as inconvenient. Your suggested idea sounds nice, and it should increase the testing speed of different defconfig configurations, without any of the dynamic modifications in internal builder functions. However, once testing is complete, the final configuration should be implemented within the mentioned functions, for the purpose detailed above. I will have a look at this next week. I'll add this to the dev branch and let you know about it. |
Hi @darkr4y , I have added a new |
With git pulling the latest code and switching to the dev branch, I tried to compile it with the following command
But only the following was generated
and I did a little bit of research, seem custom defconfig not working
Review the code and it seems to be relevant here, modified it to confirm that it generates Image.gz-dtb.
Also I found that the file Anykernel3.sh in zip seems to need to be modified as well, including:
I flashed it through LineageOS's Recovery, and
Try to use Maybe I know the issue, the AnyKernel flashable zip does not contain any ko modules (LKM). When I try following, the WIFI works well.
|
@darkr4y ,
Seems like it was something I missed, good catch.
Yes, I'm assuming that this script should be different for OP7 when compared to OP5's.
Interesting, while I did have rare Wi-Fi issues, the sound and recording issues are new to me. If I'm being honest, I can't yet provide something useful in regards to this.
I'm not sure that it should be this way, but you can try to pack the .ko file into the AnyKernel3 zip archive and execute these operations via the AnyKernel3 .sh script itself. |
It's been too long since I've responded, so I guess it's time to summarize:
Finally, most of the functions are well done, and the another process is to apply Nethunter's driver code Patch, and turn on the compilation options for the necessary functions in Defconfig REF: |
Hi @darkr4y , Yeah, I guess those are good observations. I have to admit I cannot comment too much on those notes as I've been looking more into GKI kernels, which work quite differently compared to non-GKI ones. Let me know if you're still planning to finish adding support for OP7 in here. If not, feel free to close this issue ticket; I'll check it back in some time after, and if there's no change here I'll close it myself to not keep it hanging for too long, just FYI. |
There hasn't been an update on this for quite some time, so I'm closing this issue thread. |
I will try to test this on Oneplus 7 Pro based on LineageOS, it would be nice to have a better guide for customizing the diff model. I will document the issues I encountered during my attempts in this issue and hopefully I can contribute some PR!
The text was updated successfully, but these errors were encountered: