-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seqerakit docs port #296
base: master
Are you sure you want to change the base?
Seqerakit docs port #296
Conversation
✅ Deploy Preview for seqera-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Llewellyn vd Berg <113503285+llewellyn-sl@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some feedback about formatting which we'll apply across other developer docs if we're all in agreement.
platform_versioned_docs/version-24.1/seqerakit/yaml-configuration.mdx
Outdated
Show resolved
Hide resolved
platform_versioned_docs/version-24.1/seqerakit/installation.mdx
Outdated
Show resolved
Hide resolved
…ion.mdx Co-authored-by: Justine Geffen <justinegeffen@users.noreply.github.com> Signed-off-by: Llewellyn vd Berg <113503285+llewellyn-sl@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, thank you so much!
I've added two small comments. I wouldn't consider either of these blocking. |
@llewellyn-sl, the recognized terminal highlight styles are in
|
platform_versioned_docs/version-24.1/seqerakit/installation.mdx
Outdated
Show resolved
Hide resolved
platform_versioned_docs/version-24.1/seqerakit/installation.mdx
Outdated
Show resolved
Hide resolved
platform_versioned_docs/version-24.1/seqerakit/yaml-configuration.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Esha Joshi <128735622+ejseqera@users.noreply.github.com> Signed-off-by: Llewellyn vd Berg <113503285+llewellyn-sl@users.noreply.github.com>
Co-authored-by: Esha Joshi <128735622+ejseqera@users.noreply.github.com> Signed-off-by: Llewellyn vd Berg <113503285+llewellyn-sl@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome!
Minor suggestions:
- I think Seqerakit in the descriptions qualifies as the product name and should be capitalized
--help
is an option not a parameter- Flags are boolean options (please correct me if I'm wrong)
@@ -0,0 +1,126 @@ | |||
--- | |||
title: "Commands" | |||
description: "seqerakit command options" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: "seqerakit command options" | |
description: "Seqerakit command options" |
Thoughts?
tags: [seqerakit, cli, automation, commands] | ||
--- | ||
|
||
Use the `--help` or `-h` parameter to list available commands and options: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the `--help` or `-h` parameter to list available commands and options: | |
Use the `--help` or `-h` option to list available commands and options: |
Seqerakit: Python wrapper for the Seqera Platform CLI
options:
-h, --help show this help message and exit
|
||
### Specify targets | ||
|
||
When using a YAML file as input that defines multiple resources, use the `--targets` flag to specify which resources to create. This flag accepts a comma-separated list of resource names. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When using a YAML file as input that defines multiple resources, use the `--targets` flag to specify which resources to create. This flag accepts a comma-separated list of resource names. | |
When using a YAML file as an input that defines multiple resources, use the `--targets` flag to specify which resources to create. This flag accepts a comma-separated list of resource names. |
pipelines: | ||
- name: "hello-world" | ||
url: "https://github.com/nextflow-io/hello" | ||
workspace: 'seqerakit/workspace-1' | ||
compute-env: "compute-env" | ||
... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Single vs double quotes. I'm not sure if this is important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say we should go with single to match all the values in the templates.
|
||
The Platform CLI expects to connect to a Seqera instance that is secured by a TLS certificate. If your Seqera Enterprise instance does not present a certificate, you must run your `tw` commands with the `--insecure` flag. | ||
|
||
To use `tw`-specific CLI options such as `--insecure`, use the `--cli=` flag, followed by the options to use enclosed in double quotes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To use `tw`-specific CLI options such as `--insecure`, use the `--cli=` flag, followed by the options to use enclosed in double quotes: | |
To use `tw`-specific CLI options such as `--insecure`, use the `--cli=` option, followed by the options to use enclosed in double quotes: |
For me, flag is a type of option that is reserved for booleans.
seqerakit --version | ||
``` | ||
|
||
Use the `--help` or `-h` parameter to list the available commands and their associated options: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the `--help` or `-h` parameter to list the available commands and their associated options: | |
Use the `--help` or `-h` option to list the available commands and their associated options: |
@@ -0,0 +1,117 @@ | |||
--- | |||
title: "Installation" | |||
description: "seqerakit installation options" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: "seqerakit installation options" | |
description: "Seqerakit installation options" |
@@ -0,0 +1,200 @@ | |||
--- | |||
title: "Templates" | |||
description: "seqerakit YAML configuration file templates and instructions" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: "seqerakit YAML configuration file templates and instructions" | |
description: "Seqerakit YAML configuration file templates and instructions" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! Minor feedback.
|
||
To use the templates on this page: | ||
1. Copy the template text or download the YAML files you need. | ||
1. Edit the values to specify your resource details, and save as a YML file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Edit the values to specify your resource details, and save as a YML file. | |
1. Edit the values to specify your resource details, and save as a `.yaml` file. |
To use the templates on this page: | ||
1. Copy the template text or download the YAML files you need. | ||
1. Edit the values to specify your resource details, and save as a YML file. | ||
1. Specify the YML template file in your `seqerakit` commands: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Specify the YML template file in your `seqerakit` commands: | |
1. Specify the YAML template file in your `seqerakit` commands: |
pipelines: | ||
- name: "hello-world" | ||
url: "https://github.com/nextflow-io/hello" | ||
workspace: 'seqerakit/workspace-1' | ||
compute-env: "compute-env" | ||
... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say we should go with single to match all the values in the templates.
@netlify /platform/24.1/seqerakit/installation
Ports and simplifies the Seqerakit docs into Platform Developer Tools.
TODO: