-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): Add definition of returning in SaveOptions as it was missing. #16954
Conversation
In the type definition file, the return of SaveOptions was omitted. They are present in the actual code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small code style change, but otherwise good to go
Co-authored-by: Alyx <zoe@ephys.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
🎉 This PR is included in version 6.37.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Pull Request Checklist
Have you added new tests to prevent regressions?If a documentation update is necessary, have you opened a PR to [the documentation repository](https://github.com/sequelize/website/)?Did you update the typescript typings accordingly (if applicable)?Description Of Change
In the type definition file, the return of SaveOptions was omitted.
sequelize/src/model.d.ts
Lines 1284 to 1307 in cb8ea88
They are present in the actual code.
sequelize/src/model.js
Lines 4016 to 4022 in cb8ea88
This pull request adds the missing
returning
.There was no problem with the v7 codes.
Todos