Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Umzug with mongodb fails to compile with tsc #348

Closed
olehdevua opened this issue Oct 13, 2020 · 3 comments · Fixed by #349 or #370
Closed

Umzug with mongodb fails to compile with tsc #348

olehdevua opened this issue Oct 13, 2020 · 3 comments · Fixed by #349 or #370

Comments

@olehdevua
Copy link

I use umzug to run mongodb migrations. I also use typescript in my project.
When I try to compile my project I have next error:

node_modules/umzug/lib/storage/sequelize.d.ts:3:65 - error TS2307: Cannot find module 'sequelize' or its corresponding type declarations.

3 import { Sequelize as SequelizeType, Model as ModelClass } from 'sequelize';

Is it possible to use umzug without sequelize with typescript. Maybe I'm missing something.

@mmkal
Copy link
Contributor

mmkal commented Oct 13, 2020

@olehdevua thanks for the report. This is a bug, should be possible to fix this week. Just to check - are you using v3 beta?

@papb
Copy link
Member

papb commented Oct 15, 2020

Is it possible to use umzug without sequelize with typescript. Maybe I'm missing something.

Should definitely be possible.

However, I was not able to reproduce, can you provide a minimal example? @mmkal did you reproduce it?

@mmkal
Copy link
Contributor

mmkal commented Oct 15, 2020

Yes I was able to reproduce. No problems show up in vscode but when compiling with tsc it errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants