Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It would be great if Number had an as_str method if "arbitrary_precision" is enabled. #1066

Closed
chanced opened this issue Sep 6, 2023 · 2 comments · Fixed by #1067
Closed

It would be great if Number had an as_str method if "arbitrary_precision" is enabled. #1066

chanced opened this issue Sep 6, 2023 · 2 comments · Fixed by #1067

Comments

@chanced
Copy link
Contributor

chanced commented Sep 6, 2023

Would you be open to a pull request that added an as_str method to Number if "arbitrary_precision" is enabled?
@chanced chanced changed the title It would be great if Number had an as_str method if feature "arbitrary_precision" is enabled. It would be great if Number had an as_str method if "arbitrary_precision" is enabled. Sep 6, 2023
@dtolnay
Copy link
Member

dtolnay commented Sep 6, 2023

I agree — seems good to me. Please send a PR.

@chanced
Copy link
Contributor Author

chanced commented Sep 6, 2023 •
edited
Loading

Great, on the way!

By the way, thanks for the awesome work... on all of your crates.

@chanced chanced mentioned this issue Sep 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adds as_str to Number if arbitrary_precision is enabled chanced/serde-json
2 participants
@chanced @dtolnay