Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove serialize and deserialize impls for Result #1070

Closed
dtolnay opened this issue Oct 22, 2017 · 0 comments
Closed

Remove serialize and deserialize impls for Result #1070

dtolnay opened this issue Oct 22, 2017 · 0 comments

Comments

@dtolnay
Copy link
Member

dtolnay commented Oct 22, 2017

I don't know of these impls ever being useful, and they lead to confusion when the user writes too many or too few ? or unwrap.

extern crate serde;
extern crate serde_json;

use serde::de::DeserializeOwned;

fn parse_t<T>() -> Result<T, String>
    where T: DeserializeOwned
{
    let j = r#" {} "#;

    // Compiles, but fails at runtime to deserialize `Result<T, String>`
    serde_json::from_str(j).unwrap()
}
@dtolnay dtolnay closed this as completed Oct 22, 2017
@serde-rs serde-rs locked and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

1 participant