Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please add support for NonZeroU128 #1352

Closed
Lokathor opened this issue Aug 11, 2018 · 2 comments
Closed

Please add support for NonZeroU128 #1352

Lokathor opened this issue Aug 11, 2018 · 2 comments
Labels
enhancement

Comments

@Lokathor
Copy link

It seems that NonZeroU128 isn't supported, even though NonZeroU64 is.
@pickfire
Copy link

@Lokathor Maybe it might be useful to check #1136, serde support for rustc minimum version 1.13+ does not have 128 bits integer.

@Lokathor
Copy link
Author

Yeah, seems they used a special build setup that detects the minimum rustc version and then throws in the extra impl if rustc is high enough version. I guess the same could be done for this type as well.

@hcpl hcpl mentioned this issue Sep 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dtolnay @pickfire @Lokathor