Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming Deserializer::visit_* to Deserializer::deserialize_* #151

Closed
erickt opened this issue Aug 31, 2015 · 5 comments
Closed

Consider renaming Deserializer::visit_* to Deserializer::deserialize_* #151

erickt opened this issue Aug 31, 2015 · 5 comments
Labels
enhancement
Milestone
v0.7.0

Comments

@erickt
Copy link
Member

erickt commented Aug 31, 2015

This might be a little more intuitive.
@erickt erickt mentioned this issue Aug 31, 2015
Closed
@ihrwein
Copy link

ihrwein commented Sep 4, 2015

👍

@tomprogrammer
Copy link
Contributor

Have you considered Serialize too? Only the Visitor types should have visit methods.

@erickt
Copy link
Member Author

erickt commented Sep 4, 2015

Yeah, we should do that too. The visit_* is a bit of an artifact from back when I tried super hard to merge Serializer and de::Visitor into one uber-construct, but I couldn't get that to work :(

oli-obk added a commit to oli-obk/rust-serde that referenced this issue Oct 8, 2015
@oli-obk
fix(serde-rs#151): renaming Deserializer::visit_* to Deserializer::de…
f15a2bd 
…serialize_*
oli-obk added a commit to oli-obk/rust-serde that referenced this issue Oct 19, 2015
@oli-obk
fix(serde-rs#151): renaming Deserializer::visit_* to Deserializer::de…
893935f 
…serialize_*
oli-obk added a commit to oli-obk/rust-serde that referenced this issue Oct 19, 2015
@oli-obk
fix(serde-rs#151): renaming Deserializer::visit_* to Deserializer::de…
53dc120 
…serialize_*
oli-obk added a commit to oli-obk/rust-serde that referenced this issue Oct 19, 2015
@oli-obk
test(serde-rs#151): update tests and benchmarks: visit -> (de)serialize
048d0ca
oli-obk added a commit to oli-obk/rust-serde that referenced this issue Oct 20, 2015
@oli-obk
fix(serde-rs#151): renaming Deserializer::visit_* to Deserializer::de…
56c42a9 
…serialize_*
oli-obk added a commit to oli-obk/rust-serde that referenced this issue Oct 20, 2015
@oli-obk
test(serde-rs#151): update tests and benchmarks: visit -> (de)serialize
51912e6
erickt added a commit that referenced this issue Oct 31, 2015
@erickt
Merge pull request #170 from oli-obk/master
4bdabea 
fix(#151): renaming Deserializer::visit_* to Deserializer::deserialize_*
@dovahcrow
Copy link

several traits have method visit makes me quite confused 👍

@oli-obk
Copy link
Member

oli-obk commented Nov 5, 2015

so... I think I fixed this :)

@oli-obk oli-obk closed this as completed Nov 16, 2015
@dtolnay dtolnay added this to the v0.7.0 milestone May 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
v0.7.0
Development

No branches or pull requests
6 participants
@tomprogrammer @erickt @oli-obk @dovahcrow @ihrwein @dtolnay