using with clause to open img with pil to guarantee it is closed #1174
Conversation
| # similar to find functionality, we are just considering these extensions | ||
| # content type is safer option than file extension | ||
| if file_type not in ["jpeg", "png"]: | ||
| raise ValueError(f"input image can be jpg or png, but it is {file_type}") | ||
| with Image.open(io.BytesIO(decoded_bytes)) as img: |
There was a problem hiding this comment.
This is actually not needed as in this case we're not opening a file handle: all data is already in memory (decoded_bytes). Hence the auto closure in a with block has no effect.
There was a problem hiding this comment.
Out of curiosity: why are you proxying decoded_bytes through io.BytesIO
The signature of Image.open allows to pass directly the decoded_bytes bytes object
There was a problem hiding this comment.
You mean Image.open(decoded_bytes) performs same? TBH, ChatGPT showed me that usage.
There was a problem hiding this comment.
For with block, agree it has no effect but still i believe it is good practice to confirm opened things closed.
There was a problem hiding this comment.
You mean
Image.open(decoded_bytes)performs same? TBH, ChatGPT showed me that usage.
Never ever trust ChatGPT blindly ... I beg you.
It can give you some hints but never let AI write code for you unless you have rock solid certainty it is correct, reliable and best practice. Copy pasting from ChatGPT does not tell you why some actions, statements or algos are implemented. As a developer you have to be always in the position to explain the why(s) and own the code logic.
Please.
Tickets
What has been done
With this PR, we added with close while opening file with PIL to guarantee it is closed after processed.
How to test