Feature/custom output extract faces #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@serengil |
Added grayscale parameter again. If False obey color_face, if True obey grayscale and return a warning: |
serengil
reviewed
Jul 15, 2024
deepface/modules/verification.py
Outdated
| @@ -239,7 +239,8 @@ def __extract_faces_and_embeddings( | |||
| img_objs = detection.extract_faces( | |||
| img_path=img_path, | |||
| detector_backend=detector_backend, | |||
| grayscale=False, | |||
| color_face='rgb', | |||
| normalize_face=True, | |||
There was a problem hiding this comment.
default values of color face and normalize face are rgb and True already, IMO we should not set them where it is being called if we are setting default values.
this is available also in representation, recognition, and more
There was a problem hiding this comment.
Removed them. I added it because grayscale was there.
serengil
reviewed
Jul 15, 2024
deepface/modules/verification.py
Outdated
| @@ -239,7 +239,6 @@ def __extract_faces_and_embeddings( | |||
| img_objs = detection.extract_faces( | |||
| img_path=img_path, | |||
| detector_backend=detector_backend, | |||
| grayscale=False, | |||
serengil
reviewed
Jul 15, 2024
deepface/modules/representation.py
Outdated
| @@ -71,7 +71,6 @@ def represent( | |||
| img_objs = detection.extract_faces( | |||
| img_path=img_path, | |||
| detector_backend=detector_backend, | |||
| grayscale=False, | |||
serengil
reviewed
Jul 15, 2024
deepface/modules/recognition.py
Outdated
| @@ -364,7 +363,6 @@ def __find_bulk_embeddings( | |||
| img_objs = detection.extract_faces( | |||
| img_path=employee, | |||
| detector_backend=detector_backend, | |||
| grayscale=False, | |||
serengil
reviewed
Jul 15, 2024
deepface/modules/recognition.py
Outdated
| @@ -240,7 +240,6 @@ def find( | |||
| source_objs = detection.extract_faces( | |||
| img_path=img_path, | |||
| detector_backend=detector_backend, | |||
| grayscale=False, | |||
serengil
reviewed
Jul 15, 2024
serengil
reviewed
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done
Changed extract_faces parameters to be possible to return face image (croped) as rgb, bgr or grayscale and flag for normalized. By default, all parameters will return the same as before (RGB and normalized).
How to test
Change parameters as desired:
After extracting face can save to see the result: