[WIP] Make router operations injectable #288
Conversation
tannerlinsley
commented
Jul 17, 2024
tannerlinsley
commented
- Makes router operations injectable
- Makes router context generic
- Still adheres to Remix's sessionStorage and session API's
tannerlinsley
changed the title
| @@ -74,6 +75,8 @@ | |||
| "typescript": "^5.1.6" | |||
| }, | |||
| "dependencies": { | |||
| "@tanstack/react-router": "^1.45.4", | |||
| "@tanstack/start": "^1.45.4", | |||
There was a problem hiding this comment.
This won't end up here. It would likely end up in a tanstack-auth package along with the TanStackAuthenticator class.
| sessionKey?: AuthenticateOptions<TContext>["sessionKey"]; | ||
| sessionErrorKey?: AuthenticateOptions<TContext>["sessionErrorKey"]; | ||
| sessionStrategyKey?: AuthenticateOptions<TContext>["sessionStrategyKey"]; | ||
| throwOnError?: AuthenticateOptions<TContext>["throwOnError"]; | ||
| } |
There was a problem hiding this comment.
This adds the sessionStorage to the options to bring things down to a single required options bag. This is breaking (but then again, much of this is), but has proven to be a good change in our TanStack libraries.
There was a problem hiding this comment.
This can be a non-breaking change if the current API is still implemented by the RemixAuthenticator
| redirect, | ||
| }); | ||
| } | ||
| } |
There was a problem hiding this comment.
I also imagine that this would need to stay in the "remix-auth" package while most everything else would need to go into some core package.
| Session, | ||
| SessionStorage, | ||
| } from "@remix-run/server-runtime"; | ||
| import { isSession, Session, SessionStorage } from "@remix-run/server-runtime"; |
There was a problem hiding this comment.
This is still using a Remix package, would it be ok for TSS to depend on this? This doesn't really depend on anything from Remix, maybe it could convince the team to move them to a separate agnostic package?
Another option could be to make Authenticator use another interface like's unstorage and provider wrappers of SessionStorage for unstorage in the Remix package and another in the TanStack package.
| export interface AuthenticatorImplOptions { | ||
| redirect: ( | ||
| url: string, | ||
| options?: { headers?: HeadersInit } | ||
| ) => Response | Promise<Response>; | ||
| json: <T>(data: T, status?: number) => Response; | ||
| } |
There was a problem hiding this comment.
Do you need to provide this from TanStack? At least in Remix they only wrap new Response(), in that case they could be implemented right here
