Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular V5 compatibility ? #9

Closed
JulienBourgain opened this issue Nov 13, 2017 · 3 comments · Fixed by #11
Closed

Angular V5 compatibility ? #9

JulienBourgain opened this issue Nov 13, 2017 · 3 comments · Fixed by #11

Comments

@JulienBourgain
Copy link

JulienBourgain commented Nov 13, 2017

When i do a "yarn start" of my application or of your example app with angular v5.0.1 and angular cli 1.5.0 (and rxjs 5.5.2 for angular 5) i've got this issue :

ERROR in ./node_modules/ngx-auth/index.ts
Module build failed: Error: C:\Users\julien\ngx-auth-example\node_modules\ngx-auth\index.ts is not part of the compilation output. Please check the other error messages for details.
    at AngularCompilerPlugin.getCompiledFile (C:\Users\julien\ngx-auth-example\node_modules\@ngtools\webpack\src\angular_compiler_plugin.js:629:23)
    at plugin.done.then (C:\Users\julien\ngx-auth-example\node_modules\@ngtools\webpack\src\loader.js:467:39)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)
 @ ./src/app/app-routing.module.ts 9:0-55
 @ ./src/app/app.module.ts
 @ ./src/main.ts
 @ multi webpack-dev-server/client?http://0.0.0.0:0 ./src/main.ts

I think, angular-cli doesn't compile TS files in node_modules anymore and before, it was a mistake :
angular/angular-cli#8284

So you can use somethink like this to fix that => https://github.com/dherges/ng-packagr

@serhiisol
Copy link
Owner

Hi @JulienBourgain, that's a good catch, I'll take a look at the PR.

@serhiisol serhiisol changed the title Will you work on the angular V5 compatibility ? Angular V5 compatibility ? Nov 15, 2017
@serhiisol
Copy link
Owner

serhiisol commented Nov 15, 2017

Good news, I managed to solve this problem

@serhiisol
Copy link
Owner

example application works with aot flag as well, https://github.com/serhiisol/ngx-auth-example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants