Fix/v6 read&write for windows #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1364 +/- ##
==========================================
+ Coverage 79.43% 79.58% +0.14%
==========================================
Files 21 20 -1
Lines 919 862 -57
Branches 166 162 -4
==========================================
- Hits 730 686 -44
+ Misses 189 176 -13
Continue to review full report at Codecov.
|
|
cc @dustmop |
|
LGTM |
|
This is great thank you! I'll publish a beta asap |
|
Released serialport@6.0.1 as a beta |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation to #1363, I reviewed new non-blocking read&write code for windows and noticed some potential problems.
This does not solve #1363, but I think they should be fixed.