Alpine Linux: Adds missing header file for musl libc #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure if there are other potential problems lurking here for musl but this should fix the custom baudrate problem. Waiting on confirmation before PR.
reconbot
approved these changes
Feb 15, 2018
|
👏 |
|
I'll do another beta release this evening once travis's build queues empty out. |
IvanSanchez
pushed a commit
to NordicPlayground/node-serialport
that referenced
this pull request
Feb 27, 2018
…lport#1487) Fixes serialport#1470 After adding the new custom baud rate implementation for Linux, a build breaking bug occurred on Alpine Linux due to musl's handling of the kernel header files involved with ioctls. This patch introduces a fix by using the solution found [here](tio/tio#65) on a similar, serial oriented project. Tested in an Alpine Linux docker container. Passing all hardware tests.
oteku
pushed a commit
to Cutii/node-serialport
that referenced
this pull request
Apr 9, 2018
…lport#1487) Fixes serialport#1470 After adding the new custom baud rate implementation for Linux, a build breaking bug occurred on Alpine Linux due to musl's handling of the kernel header files involved with ioctls. This patch introduces a fix by using the solution found [here](tio/tio#65) on a similar, serial oriented project. Tested in an Alpine Linux docker container. Passing all hardware tests.
reconbot
pushed a commit
that referenced
this pull request
Jul 24, 2018
Fixes #1470 After adding the new custom baud rate implementation for Linux, a build breaking bug occurred on Alpine Linux due to musl's handling of the kernel header files involved with ioctls. This patch introduces a fix by using the solution found [here](tio/tio#65) on a similar, serial oriented project. Tested in an Alpine Linux docker container. Passing all hardware tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1470 After adding the new custom baud rate implementation for Linux, a build breaking bug occurred on Alpine Linux due to musl's handling of the kernel header files involved with ioctls. This patch introduces a fix by using the solution found here on a similar, serial oriented project.
Tested in an Alpine Linux docker container. Passing all hardware tests.