Fixed EIO_List to prevent crash when a device has no COM port #2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 29, 2021
|
While I don't have a brother device that exhibits this issue, I can confirm that this doesn't seem to cause regressions for normal windows usage :-) The only other item which isn't initialised upon each loop is serialNumber... not sure if that is worth a quick change in case that is causing any other issues... |
GazHank
added a commit
to GazHank/node-serialport
that referenced
this pull request
Oct 10, 2021
Signed-off-by: Gareth Hancock <64541249+GazHank@users.noreply.github.com>
reconbot
pushed a commit
that referenced
this pull request
Nov 26, 2021
Signed-off-by: Gareth Hancock <64541249+GazHank@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed EIO_List to prevent crash when a device has no COM port, see:
#1830
#2259
#2155