Skip to content
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.

Port buffer file improvements from Serilog.Sinks.Seq #179

Closed
nvivo opened this issue Jun 14, 2018 · 4 comments
Closed

Port buffer file improvements from Serilog.Sinks.Seq #179

nvivo opened this issue Jun 14, 2018 · 4 comments

Comments

@nvivo
Copy link

nvivo commented Jun 14, 2018

Currently, this sink is using RollingFile as buffer, and it has some serious limitations, that whether the buffer file grows without limits, or the file is size-limited and the sink stops working after that. This is making the durable mode unusable with this sink.

I'm currently using the sink without durable mode, but this is a problem as some events may go missing for various reasons. The Seq sink had the same issues, and they were fixed on version 4.0. It would be great if these changes, that is datalust/serilog-sinks-seq#92 and datalust/serilog-sinks-seq#99 would be ported to this sink.

@nvivo
Copy link
Author

nvivo commented Jun 18, 2018

Is it possible to pay to get this implemented? Is anyone interested in resolving this?

@mivano
Copy link
Contributor

mivano commented Jun 18, 2018

Would love to have a better/improved version of the buffer, unfortunately too little time to implement. IMHO it would also be nice if this was a more generic Serilog buffer which would pick up events when the configured sink was unable to work.

@nvivo
Copy link
Author

nvivo commented Jun 19, 2018

I currently have this sink and the seq sink logging the same events. For some reason, I have lots of missing events in elastic search that are not logged nor reported in the failure sink/self log. I enabled the selflog, and eventually I get a few failures, but that is probably 1% of what is missing on elastic search.

I'm betting the lack of durable mode is the problem, but that's just a guess. I'll try to debug this at some point.

@mivano
Copy link
Contributor

mivano commented Dec 16, 2019

Old issue, cleaning up. There have been some improvement. Still facing this issue, feel free to reopen.

@mivano mivano closed this as completed Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants