Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Environment.User* on .NET Standard 2.0 #37

Merged
merged 1 commit into from
Jun 29, 2020

Conversation

0xced
Copy link
Member

@0xced 0xced commented Jun 23, 2020

Using negative target framework conditions to define the ENV_USER_NAME constant so that if a new target framework is added it will automatically opt-in to ENV_USER_NAME.

Using negative target framework conditions to define the ENV_USER_NAME constant so that if a new target framework is added it will automatically opt-in to ENV_USER_NAME.
@nblumhardt nblumhardt merged commit c61912a into serilog:dev Jun 29, 2020
@nblumhardt
Copy link
Member

Thank you 👍

@0xced
Copy link
Member Author

0xced commented Aug 1, 2020

Thanks for merging! Are you planing to release a new version of the NuGet package?

@0xced 0xced deleted the use-environment-static-properties branch August 1, 2020 09:19
@nblumhardt nblumhardt mentioned this pull request Aug 2, 2020
@nblumhardt
Copy link
Member

Opened #38 - thanks for the nudge :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants