Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ValueTuple<string, object> as state of scope. #186

Open
quabug opened this issue Mar 1, 2021 · 2 comments
Open

Support ValueTuple<string, object> as state of scope. #186

quabug opened this issue Mar 1, 2021 · 2 comments

Comments

@quabug
Copy link

quabug commented Mar 1, 2021

It would be nice to code like logger.BeginScope(("propertyName", (object)property)) or even better with an extension public static IDisposable BeginScope(this ILogger logger, string name, object value).

@nblumhardt
Copy link
Member

Definitely a syntactic improvement; the first variant would be the preferred one since consumers of this library don't normally want to depend on additional libraries to add things like the extra BeginScope overload.

Would be great if anyone watching along has the opportunity to explore this further/open a PR for discussion.

@sungam3r
Copy link
Contributor

Can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants