You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The naming scheme we used for config options / command-line options seems to be somewhat inconsistent. We often use the imperative mood (e.g. ignoreRefs, checkLocalHost, ignoreAuthFailures), but sometimes use the past tense (e.g. ignored, notScanned).
We should use a consistent naming scheme.
In #118 (comment) I suggested deleting ignored and having only notScanned. If we do that, then we can rename notScanned to ignore, which would solve this issue.
If we end up going in a different direction in #118, then we should have a discussion about how to rename these two options.
Acceptance criteria
We consistently use the imperative mood when naming config options / command-line options.
The text was updated successfully, but these errors were encountered:
Clarification and motivation
BLOCKED BY #118
The naming scheme we used for config options / command-line options seems to be somewhat inconsistent. We often use the imperative mood (e.g.
ignoreRefs
,checkLocalHost
,ignoreAuthFailures
), but sometimes use the past tense (e.g.ignored
,notScanned
).We should use a consistent naming scheme.
In #118 (comment) I suggested deleting
ignored
and having onlynotScanned
. If we do that, then we can renamenotScanned
toignore
, which would solve this issue.If we end up going in a different direction in #118, then we should have a discussion about how to rename these two options.
Acceptance criteria
We consistently use the imperative mood when naming config options / command-line options.
The text was updated successfully, but these errors were encountered: