Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of master alias #58

Merged
merged 8 commits into from
Jun 21, 2017
Merged

Removal of master alias #58

merged 8 commits into from
Jun 21, 2017

Conversation

HyperBrain
Copy link
Member

Fixes #56

As soon as all deployed aliases have been removed, it is possible to remove the service by removing the master alias.

@serverless-heaven serverless-heaven deleted a comment from coveralls Jun 20, 2017
@serverless-heaven serverless-heaven deleted a comment from coveralls Jun 21, 2017
@HyperBrain
Copy link
Member Author

The implementation is finished and should do as expected. The coverage has to be turned positive now. Then it can be merged.

@serverless-heaven serverless-heaven deleted a comment from coveralls Jun 21, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+5.3%) to 60.08% when pulling 29046f4 on removal-of-master-alias into 928a66c on master.

@serverless-heaven serverless-heaven deleted a comment from coveralls Jun 21, 2017
@serverless-heaven serverless-heaven deleted a comment from coveralls Jun 21, 2017
@HyperBrain
Copy link
Member Author

Did the final tests. Everything workes as expected now.

@HyperBrain HyperBrain merged commit 7cc0d82 into master Jun 21, 2017
@HyperBrain HyperBrain deleted the removal-of-master-alias branch June 21, 2017 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants