-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit tests fail on Windows because of path separator #145
Comments
Perhaps we could use AppVeyor to run the tests on a Windows-based CI in the future? |
Sounds like a good idea. This would complement Travis (where we can run linux and osx tests) perfectly. I will take care of the Travis integration in the next days, and will do some experiments with AppVeyor too. |
The issue on Windows is not just replacing the path separators. After fixing these, the unit tests on Windows still bail out with a failing require that seems to behave differently on Windows and Linux. Did the same test on Linux and it worked. |
Will suspend work on this, until the code base for 3.0.0 is ready. Due to the removal of serve and run, the unit tests should be runnable on Windows again with only a few changes. |
V3 merged |
This is a Bug Report
Description
When running
npm test
on Windows, the unit tests fail like:The failures happen in multiple tests, everywhere where paths are checked against
their expectations.
Proposed solution
The expectations should be composed by using
path.sep
as path separator to keep the tests platform independent.The text was updated successfully, but these errors were encountered: