Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spawn EINVAL on Windows when using Node > 20.12.2 #1793

Merged
merged 1 commit into from
May 17, 2024
Merged

Fix spawn EINVAL on Windows when using Node > 20.12.2 #1793

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,12 @@ class SpawnError extends Error {
*/
function spawnProcess(command, args, options) {
return new BbPromise((resolve, reject) => {
const child = childProcess.spawn(command, args, options);
const child = childProcess.spawn(command, args, {
...options,
vicary marked this conversation as resolved.
Show resolved Hide resolved
// nodejs 20 on windows doesn't allow `.cmd` command to run without `shell: true`
// https://github.com/serverless-heaven/serverless-webpack/issues/1791
shell: /^win/.test(process.platform)
});
let stdout = '';
let stderr = '';
// Configure stream encodings
Expand Down
Loading