Skip to content
This repository has been archived by the owner on Jan 28, 2025. It is now read-only.

fix(nextjs-cdk-construct): use posix paths for s3 assets and invalida… #1025

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Apr 28, 2021

…tions

@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #1025 (35e6980) into master (f18d6a6) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1025   +/-   ##
=======================================
  Coverage   82.32%   82.32%           
=======================================
  Files          69       69           
  Lines        2574     2574           
  Branches      613      613           
=======================================
  Hits         2119     2119           
  Misses        389      389           
  Partials       66       66           
Impacted Files Coverage Δ
...rless-components/nextjs-cdk-construct/src/index.ts 92.98% <ø> (ø)
...tjs-cdk-construct/src/utils/readAssetsDirectory.ts 100.00% <100.00%> (ø)
...uct/src/utils/readInvalidationPathsFromManifest.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f18d6a6...35e6980. Read the comment docs.

Copy link
Collaborator

@kirkness kirkness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @dphang - unable to test this myself

@dphang dphang merged commit b8b4393 into master Apr 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the dphang/cdk-posix-paths branch April 28, 2021 18:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants