This repository has been archived by the owner on Jan 28, 2025. It is now read-only.
fix(sls-next/cdk-construct): defaultBehavior.edgeLambdas only applied to defaultBehavior #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to defaultBehavior was also applied to _next/data/* behaviour
Codecov Report
@@ Coverage Diff @@
## master #1031 +/- ##
==========================================
- Coverage 82.31% 82.30% -0.01%
==========================================
Files 69 69
Lines 2578 2577 -1
Branches 615 615
==========================================
- Hits 2122 2121 -1
Misses 390 390
Partials 66 66
Continue to review full report at Codecov.
|
dphang
approved these changes
Apr 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing
defaultBehavior.edgeLambdaswas being applied todefaultBehaviorand to_next/data/*behaviour. Could cause unintended side effects.