Skip to content
This repository has been archived by the owner on Jan 28, 2025. It is now read-only.

feat(aws-s3, nextjs-component): support s3 bucket tags #1326

Merged
merged 3 commits into from
Jun 29, 2021

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Jun 29, 2021

  • Also imported aws-s3 package

@slsnextbot
Copy link
Collaborator

slsnextbot commented Jun 29, 2021

Handler Size Report

No changes to handler sizes.

Base Handler Sizes (kB) (commit c36df60)

{
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1231,
            "Minified": 435
        },
        "API Lambda": {
            "Standard": 81,
            "Minified": 33
        },
        "Image Lambda": {
            "Standard": 903,
            "Minified": 357
        },
        "Regeneration Lambda": {
            "Standard": 629,
            "Minified": 223
        }
    }
}

New Handler Sizes (kB) (commit 529bec4)

{
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1231,
            "Minified": 435
        },
        "API Lambda": {
            "Standard": 81,
            "Minified": 33
        },
        "Image Lambda": {
            "Standard": 903,
            "Minified": 357
        },
        "Regeneration Lambda": {
            "Standard": 629,
            "Minified": 223
        }
    }
}

@dphang dphang marked this pull request as draft June 29, 2021 06:46
@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #1326 (529bec4) into master (c36df60) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1326   +/-   ##
=======================================
  Coverage   83.61%   83.61%           
=======================================
  Files          97       97           
  Lines        3345     3345           
  Branches     1001     1001           
=======================================
  Hits         2797     2797           
  Misses        486      486           
  Partials       62       62           
Impacted Files Coverage Δ
...rless-components/nextjs-component/src/component.ts 90.27% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c36df60...529bec4. Read the comment docs.

@dphang dphang marked this pull request as ready for review June 29, 2021 17:04
@dphang dphang merged commit c924c22 into master Jun 29, 2021
@delete-merged-branch delete-merged-branch bot deleted the dphang/bucket-tags branch June 29, 2021 17:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants