Skip to content
This repository has been archived by the owner on Jan 28, 2025. It is now read-only.

fix(lambda-at-edge): copy next-i18next files to regeneration handler #1653

Merged
merged 3 commits into from
Sep 8, 2021

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Sep 8, 2021

Fix for #1634

@slsnextbot
Copy link
Collaborator

slsnextbot commented Sep 8, 2021

Handler Size Report

No changes to handler sizes.

Base Handler Sizes (kB) (commit a56dd82)

{
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1253,
            "Minified": 448
        },
        "API Lambda": {
            "Standard": 99,
            "Minified": 44
        },
        "Image Lambda": {
            "Standard": 918,
            "Minified": 368
        },
        "Regeneration Lambda": {
            "Standard": 645,
            "Minified": 235
        }
    }
}

New Handler Sizes (kB) (commit ca332bf)

{
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1253,
            "Minified": 448
        },
        "API Lambda": {
            "Standard": 99,
            "Minified": 44
        },
        "Image Lambda": {
            "Standard": 918,
            "Minified": 368
        },
        "Regeneration Lambda": {
            "Standard": 645,
            "Minified": 235
        }
    }
}

@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #1653 (ca332bf) into master (a56dd82) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1653   +/-   ##
=======================================
  Coverage   84.22%   84.23%           
=======================================
  Files          98       98           
  Lines        3442     3444    +2     
  Branches     1020     1022    +2     
=======================================
+ Hits         2899     2901    +2     
  Misses        483      483           
  Partials       60       60           
Impacted Files Coverage Δ
packages/libs/lambda-at-edge/src/build.ts 96.66% <100.00%> (ø)
...-at-edge/src/build/third-party/integration-base.ts 100.00% <100.00%> (ø)
...mbda-at-edge/src/build/third-party/next-i18next.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a56dd82...ca332bf. Read the comment docs.

@dphang dphang merged commit 1c14f38 into master Sep 8, 2021
@delete-merged-branch delete-merged-branch bot deleted the dphang/regeneration-next-i18 branch September 8, 2021 21:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants