Skip to content
This repository has been archived by the owner on Jan 28, 2025. It is now read-only.

fix(core): fallback to using page's html render function when html is… #1680

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Sep 13, 2021

… empty

@slsnextbot
Copy link
Collaborator

Handler Size Report

No changes to handler sizes.

Base Handler Sizes (kB) (commit d28e4d8)

{
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1401,
            "Minified": 495
        },
        "API Lambda": {
            "Standard": 100,
            "Minified": 44
        },
        "Image Lambda": {
            "Standard": 918,
            "Minified": 368
        },
        "Regeneration Lambda": {
            "Standard": 645,
            "Minified": 235
        }
    }
}

New Handler Sizes (kB) (commit 2f8d7b5)

{
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1401,
            "Minified": 495
        },
        "API Lambda": {
            "Standard": 100,
            "Minified": 44
        },
        "Image Lambda": {
            "Standard": 918,
            "Minified": 368
        },
        "Regeneration Lambda": {
            "Standard": 645,
            "Minified": 235
        }
    }
}

@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #1680 (546272a) into master (d28e4d8) will increase coverage by 0.01%.
The diff coverage is 50.00%.

❗ Current head 546272a differs from pull request most recent head 2f8d7b5. Consider uploading reports for the commit 2f8d7b5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1680      +/-   ##
==========================================
+ Coverage   84.14%   84.15%   +0.01%     
==========================================
  Files          98       98              
  Lines        3449     3452       +3     
  Branches     1027     1028       +1     
==========================================
+ Hits         2902     2905       +3     
  Misses        485      485              
  Partials       62       62              
Impacted Files Coverage Δ
packages/libs/core/src/utils/renderUtils.ts 84.61% <50.00%> (+4.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d28e4d8...2f8d7b5. Read the comment docs.

@dphang dphang merged commit ef38698 into master Sep 13, 2021
@dphang dphang mentioned this pull request Sep 13, 2021
3 tasks
@dphang dphang deleted the dphang/update-render-utils branch September 13, 2021 20:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants