Skip to content
This repository has been archived by the owner on Jan 28, 2025. It is now read-only.

fix(nextjs-cdk-construct): disable public read access of s3 bucket an… #1758

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Sep 27, 2021

…d allow all methods in default behavior

@slsnextbot
Copy link
Collaborator

Handler Size Report

No changes to handler sizes.

Base Handler Sizes (kB) (commit 0553f75)

{
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1061,
            "Minified": 382
        },
        "Default Lambda V2": {
            "Standard": 1536,
            "Minified": 660
        },
        "API Lambda": {
            "Standard": 101,
            "Minified": 44
        },
        "Image Lambda": {
            "Standard": 943,
            "Minified": 375
        },
        "Regeneration Lambda": {
            "Standard": 665,
            "Minified": 242
        },
        "Regeneration Lambda V2": {
            "Standard": 695,
            "Minified": 267
        }
    }
}

New Handler Sizes (kB) (commit f7298fe)

{
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1061,
            "Minified": 382
        },
        "Default Lambda V2": {
            "Standard": 1536,
            "Minified": 660
        },
        "API Lambda": {
            "Standard": 101,
            "Minified": 44
        },
        "Image Lambda": {
            "Standard": 943,
            "Minified": 375
        },
        "Regeneration Lambda": {
            "Standard": 665,
            "Minified": 242
        },
        "Regeneration Lambda V2": {
            "Standard": 695,
            "Minified": 267
        }
    }
}

@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #1758 (ad1651b) into master (0553f75) will not change coverage.
The diff coverage is n/a.

❗ Current head ad1651b differs from pull request most recent head f7298fe. Consider uploading reports for the commit f7298fe to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1758   +/-   ##
=======================================
  Coverage   83.88%   83.88%           
=======================================
  Files          98       98           
  Lines        3499     3499           
  Branches     1051     1051           
=======================================
  Hits         2935     2935           
  Misses        500      500           
  Partials       64       64           
Impacted Files Coverage Δ
...rless-components/nextjs-cdk-construct/src/index.ts 93.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0553f75...f7298fe. Read the comment docs.

@dphang dphang merged commit 770641c into master Sep 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the dphang/cdk-s3-permissions branch September 28, 2021 00:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants