Skip to content
This repository has been archived by the owner on Jan 28, 2025. It is now read-only.

feat(nextjs-component, aws-lambda): allow removing old lambda versions #1884

Merged
merged 4 commits into from
Oct 23, 2021

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Oct 22, 2021

  • Use inputs. removeOldLambdaVersions = true in serverless.yml to enable. This allows a basic removal strategy of all versions except the latest deployed/replicated Lambdas (up to 50 at a time).

@slsnextbot
Copy link
Collaborator

Handler Size Report

There are changes to handler sizes. Please review.

Base Handler Sizes (kB) (commit 7de14a4)

{}

New Handler Sizes (kB) (commit d023ee7)

{
    "Lambda": {
        "Default Lambda": {
            "Standard": 1495,
            "Minified": 658
        },
        "Image Lambda": {
            "Standard": 1460,
            "Minified": 791
        }
    },
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1507,
            "Minified": 664
        },
        "Default Lambda V2": {
            "Standard": 1498,
            "Minified": 660
        },
        "API Lambda": {
            "Standard": 632,
            "Minified": 318
        },
        "Image Lambda": {
            "Standard": 1468,
            "Minified": 796
        },
        "Regeneration Lambda": {
            "Standard": 589,
            "Minified": 241
        },
        "Regeneration Lambda V2": {
            "Standard": 655,
            "Minified": 267
        }
    }
}

@codecov
Copy link

codecov bot commented Oct 23, 2021

Codecov Report

Merging #1884 (d023ee7) into master (0db295f) will increase coverage by 0.20%.
The diff coverage is 90.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1884      +/-   ##
==========================================
+ Coverage   83.73%   83.93%   +0.20%     
==========================================
  Files          99      100       +1     
  Lines        3522     3535      +13     
  Branches     1077     1072       -5     
==========================================
+ Hits         2949     2967      +18     
- Misses        509      510       +1     
+ Partials       64       58       -6     
Impacted Files Coverage Δ
...rless-components/nextjs-component/src/component.ts 86.87% <80.00%> (+1.61%) ⬆️
...-components/aws-lambda/src/removeLambdaVersions.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7de14a4...d023ee7. Read the comment docs.

@dphang dphang merged commit 0110f0a into master Oct 23, 2021
@delete-merged-branch delete-merged-branch bot deleted the dphang/remove-old-code-versions branch October 23, 2021 02:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants