This repository has been archived by the owner on Jan 28, 2025. It is now read-only.
fix(lambda-at-edge): fix dynamic route precedence conflicting with fallback pages #714
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #646
A bit strange to mix this with static fallback logic, but the issue is fallback is checked early in the routing logic before any non-dynamic or dynamic routes, hence we need to check this as part of it. Will revisit this and do a cleaner refactor once we decouple Lambda@Edge and core routing logic.
Tests
Added some end-to-end tests to verify this behavior.