Skip to content
This repository has been archived by the owner on Jan 28, 2025. It is now read-only.

fix(nextjs-component): don't override _next/image* and _next/static/*… #859

Merged
merged 2 commits into from
Jan 2, 2021

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Jan 2, 2021

… origin request lambda with the default lambda

  • For _next/static/* and _next/image* cache behaviors, they should not be overridden with default lambda (_next/static/* should have no lambda, and _next/image* should retain the image lambda).
  • Also clean up unneeded config in test next-app

@codecov
Copy link

codecov bot commented Jan 2, 2021

Codecov Report

Merging #859 (4d134b0) into master (6adaf00) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #859   +/-   ##
=======================================
  Coverage   80.55%   80.56%           
=======================================
  Files          63       63           
  Lines        2242     2243    +1     
  Branches      505      506    +1     
=======================================
+ Hits         1806     1807    +1     
  Misses        376      376           
  Partials       60       60           
Impacted Files Coverage Δ
...rless-components/nextjs-component/src/component.ts 91.35% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6adaf00...4d134b0. Read the comment docs.

@dphang dphang merged commit 20e513c into master Jan 2, 2021
@delete-merged-branch delete-merged-branch bot deleted the dphang/fix-next-static-override branch January 2, 2021 19:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant