Skip to content
This repository has been archived by the owner on Jan 28, 2025. It is now read-only.

fix(lambda-at-edge): locale subpath bug fixes #888

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Jan 26, 2021

  • SSG index page routing
  • static pages / json files only in locale directories
  • separate unit tests for locale testing with/without basepath

Related: #721

* SSG index page routing
* static pages / json files only in locale directories
* separate unit tests for locale testing with/without basepath
@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #888 (95e000f) into master (8e39294) will increase coverage by 0.35%.
The diff coverage is 95.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #888      +/-   ##
==========================================
+ Coverage   80.36%   80.72%   +0.35%     
==========================================
  Files          64       64              
  Lines        2394     2402       +8     
  Branches      550      560      +10     
==========================================
+ Hits         1924     1939      +15     
+ Misses        407      399       -8     
- Partials       63       64       +1     
Impacted Files Coverage Δ
...es/libs/lambda-at-edge/src/routing/locale-utils.ts 95.83% <87.50%> (-4.17%) ⬇️
packages/libs/lambda-at-edge/src/build.ts 90.18% <92.30%> (+0.99%) ⬆️
...ackages/libs/lambda-at-edge/src/default-handler.ts 93.37% <100.00%> (+1.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e39294...95e000f. Read the comment docs.

@dphang dphang merged commit f9a6787 into master Jan 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the dphang/locale-fixes branch January 26, 2021 07:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant