Skip to content
This repository has been archived by the owner on Jan 28, 2025. It is now read-only.

fix(s3-static-assets): always use posix path join for fast-glob in re… #940

Merged
merged 2 commits into from
Mar 10, 2021

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Mar 10, 2021

…adDirectoryFiles

  • On windows, path.join returns paths separated by backslashes, but fast-glob only accepts posix paths.

In the future, we should run at least the unit tests on Windows workflow to ensure it doesn't break.

Should fix: #932

@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #940 (f47e287) into master (81d9d18) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #940   +/-   ##
=======================================
  Coverage   81.39%   81.39%           
=======================================
  Files          69       69           
  Lines        2516     2516           
  Branches      599      599           
=======================================
  Hits         2048     2048           
  Misses        401      401           
  Partials       67       67           
Impacted Files Coverage Δ
...ibs/s3-static-assets/src/lib/readDirectoryFiles.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81d9d18...ba8497f. Read the comment docs.

@dphang dphang merged commit d513192 into master Mar 10, 2021
@delete-merged-branch delete-merged-branch bot deleted the dphang/fix-fast-glob branch March 10, 2021 07:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The files under the 'assets' not uploaded to S3
1 participant