Skip to content
This repository has been archived by the owner on Jan 28, 2025. It is now read-only.

fix(lambda-at-edge): ensure dist/sharp_node_modules empty before copying #980

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Apr 2, 2021

Fixes: #979 - seems this directory was growing indefinitely with each publish from my machine without this fix, it was not caught in e2e tests since that doesn't deploy from a published package, but instead builds locally from scratch (so dist/sharp_node_modules would not exist on each CI run).

Will likely deprecate last few versions which may cause this issue (and unnecessarily use Lambda space)

@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #980 (0676e38) into master (668353f) will not change coverage.
The diff coverage is n/a.

❗ Current head 0676e38 differs from pull request most recent head e977df4. Consider uploading reports for the commit e977df4 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #980   +/-   ##
=======================================
  Coverage   81.49%   81.49%           
=======================================
  Files          69       69           
  Lines        2534     2534           
  Branches      603      603           
=======================================
  Hits         2065     2065           
  Misses        402      402           
  Partials       67       67           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 668353f...e977df4. Read the comment docs.

@dphang dphang merged commit c43b2f8 into master Apr 2, 2021
@delete-merged-branch delete-merged-branch bot deleted the dphang/fix-image-node-modules-size branch April 2, 2021 06:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RequestEntityTooLargeException randomly began erroring on deploys
1 participant