Test sample app in CI #165
Conversation
In addition to the conformance test suite, we should also start to test our samples. This change updates the spring-petclinic sample to use kapp to deploy and updates the sample readme to describe the benefits of kapp and how we leverage them for the sample. Signed-off-by: Scott Andrews <andrewssc@vmware.com>
| - name: Test samples | ||
| run: | | ||
| set -o errexit | ||
| set -o nounset | ||
| set -o pipefail | ||
|
|
||
| echo "##[group]Deploy spring-petclinic" | ||
| ${KAPP} deploy -a servicebinding-sample-spring-petclinic -n apps --wait-timeout 5m -y \ | ||
| -f samples/spring-petclinic | ||
| echo "##[endgroup]" |
There was a problem hiding this comment.
Q: Does it make sense to have these in the same run pipeline as conformance tests? If these break, I don't want them to gate running conformance tests (or vice-versa, for that matter).
There was a problem hiding this comment.
it's running in the acceptance job. I view conformance as one part of acceptance for the RI. If there's a change that breaks a basic e2e app, we know the change isn't going to pass conformant (I hope). If you prefer, I can move this after the conformance tests.
There was a problem hiding this comment.
I was hoping to have a little more granularity in tests here. For now, it'll probably be fine (since we're still trying to get out of bootstrapping testing), but long-term I'd prefer to have separate pipeline stages for separate test suites.
In addition to the conformance test suite, we should also start to test our samples. This change updates the spring-petclinic sample to use kapp to deploy and updates the sample readme to describe the benefits of kapp and how we leverage them for the sample. Signed-off-by: Scott Andrews <andrewssc@vmware.com>
In addition to the conformance test suite, we should also start to test
our samples. This change updates the spring-petclinic sample to use kapp
to deploy and updates the sample readme to describe the benefits of kapp
and how we leverage them for the sample.
Signed-off-by: Scott Andrews andrewssc@vmware.com