Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.5.1 breaking crates.io CI #936

Closed
Turbo87 opened this issue Jun 10, 2024 · 1 comment
Closed

v2.5.1 breaking crates.io CI #936

Turbo87 opened this issue Jun 10, 2024 · 1 comment

Comments

@Turbo87
Copy link

Turbo87 commented Jun 10, 2024

The crates.io codebase received an automated pull request to update the url crate from v2.5.0 to v2.5.1, and it looks like that update it breaking our CI test suite. From the looks of it, some tests start failing and then the whole cargo test process just gives up and is silently killed, skipping all the remaining steps in the CI pipeline. Unfortunately, I don't have much more information yet, but to me this looks like a potential out-of-memory issue, although we're not actually using that many URL instances.

The change that stands out in the url release is #923, due to its size and significance, though I don't know yet whether this is the actual cause. It seems a bit unfortunate though that this was released in a bug-fix release, given the size of the diff.

If I can get more information out of our CI system I will update this issue accordingly.

@Turbo87
Copy link
Author

Turbo87 commented Jun 11, 2024

After deleting all caches and re-running CI it suddenly started working correctly, so this may have been a caching issue at some level. I'll close this issue since the root cause of the problem is apparently somewhere else.

@Turbo87 Turbo87 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant