Cleanup matrix and run tests in CI #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
jdm
approved these changes
Nov 23, 2024
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
|
I've added f7280b6 that ignores some bad results from angle. BTW I do not have permissions to land in surfman :( |
|
I just fixed the repo settings; the Maintainers team only had read access for some reason. |
I still have: |
|
I have now added the maintainers team to the list of authorized users. |
|
It works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered in #321 that we do not run any test in CI, so I cleaned up matrix, run tests on native platforms (use wayland/x11 emulation on linux) and fix examples (mostly by removing support for rwh05 that wasn't working anyway). I think it should be safe to remove rwh05 as winit only supports rwh06, but that should be done as a followup.